- strftime -> date.
- strftime is same as date, but with locales.
- date format doesn't output names (January, March, etc.),
so locale doesn't matter.
- also, would we really want locale in logs?
- Log::log() internally support array implode,
so no need to duplicate functionality.
- however, the internal implode uses two consecutive spaces as separator,
so this will change the log format slightly.
e.g. "delta=x now=y" becomes "delta=x now=y"
- same as 1e799aa6e5.
- group $timeout filtering and validation.
- this commit might change replies sent to clients,
since the validation check is done eaerlier now,
and we might return S_MISSING_PARAM before S_BAD_OTP for example.
- this should really not cause any issues though,
the order of which error is raised first should not matter to clients.
- group $sl filtering and validation.
- this commit might change replies sent to clients,
since the validation check is done eaerlier now,
and we might return S_MISSING_PARAM before S_BAD_OTP for example.
- this should really not cause any issues though,
the order of which error is raised first should not matter to clients.
- this commit might affect LOG_DEBUG message,
since now we log utf8_encode($qs) not $qs.
- this is probably what we want though,
since we run hash_hmac on the latter.
- negate test and return early.
- avoid wrapping whole function in `if () { }`.
- move $condition below $arr,
since $arr is passwed first, then $condition, to conditionalUpdateBy().
- don't repeat config-db.php file path
- add @is_readable,
we might not have the proper permissions.
- use 'require_once' instead of 'include',
this file should only be included once and we
should fail dramatically if we can't load it.
- better documentation.
