rooty/yubikey-val
1
0
Fork 0
mirror of https://github.com/Yubico/yubikey-val.git synced 2025-02-01 19:52:20 +01:00
Code Issues Projects Releases Wiki Activity
665 Commits 7 Branches 44 Tags
Commit Graph

100 Commits

Author SHA1 Message Date
Jean Paul Galea
3aecc617c3 Fix bug. 
- this was not introduced by my refactoring.

- LOG_ALERT for; yk_low, yk_high, nonce was written only
	if yk_use failed to be parsed.

- as a result, this commit might change LOG_ALERT output.
 2015-07-17 23:35:15 +02:00
Jean Paul Galea
a0f57bd674 Cosmetic changes. 2015-07-17 23:33:29 +02:00
Jean Paul Galea
be4ee3116e Cosmetic changes. 2015-07-17 23:30:57 +02:00
Jean Paul Galea
60d1e7e302 Refactor away useless else { } wrap. 2015-07-17 23:27:43 +02:00
Jean Paul Galea
9869bfe84d Cosmetic changes. 2015-07-17 23:25:52 +02:00
Jean Paul Galea
afc81e484a Refactor away useless variable. 2015-07-17 23:22:27 +02:00
Jean Paul Galea
a20b0b69ae Cosmetic changes. 2015-07-17 23:21:22 +02:00
Jean Paul Galea
acfafc5d72 Refactor. 
- be explicit and declare as public,
	since we're clearly using it.
 2015-07-17 23:17:37 +02:00
Jean Paul Galea
5a272cf928 Refactor. 
- remove unnecessary else { } wrap.
 2015-07-17 23:07:17 +02:00
Jean Paul Galea
fd5391bb91 Cosmetic changes. 2015-07-17 23:06:21 +02:00
Jean Paul Galea
a0de5b9fd5 Refactor. 
- str sub instead of concat
 2015-07-17 23:03:40 +02:00
Jean Paul Galea
ef6adeb826 Cosmetic changes. 
- adhere with some form of convetion for comments.

- use single quotes where possible.
 2015-07-17 22:48:35 +02:00
Jean Paul Galea
13530c532f Cosmetic changes. 2015-07-17 22:38:43 +02:00
Jean Paul Galea
c5b6b3c567 Refactor. 
- retrieveURLasync() always returns FALSE on failure now,
	before it might have returned a string.

- use array_shift($a) to pop first element,
	safer than $a[0];

- this commit might affect what is written to LOG_DEBUG,
	since now we only write the YK-KSM message when we
	are certain to have a valid response.
 2015-07-17 22:25:42 +02:00
Jean Paul Galea
60a487a996 Cosmetic changes. 2015-07-17 22:12:59 +02:00
Jean Paul Galea
bc5319327b Unwrap function. 2015-07-16 22:35:34 +02:00
Jean Paul Galea
731eed8fa9 Refactor. 
- syncServers was mostly always an array.

- change init value from NULL to array().

- simplify getNumberOfServers.
 2015-07-16 22:31:51 +02:00
Jean Paul Galea
057eb0b563 Removed dead code, second try. 
- grep with -i switch.

- left UnixToDbTime...
	will refactor later and unwrap to plain date()

- left timestamp* methods in ykval-db,
	not used but might be useful while refactoring other code.
 2015-07-16 22:07:39 +02:00
Jean Paul Galea
b4f9bd4939 Revert "Removed dead code." 
This reverts commit 29deb6007dd66a47ab9275687fcac140a228e404.

PHP functions are __not__ case-sensitive!
 2015-07-16 15:44:35 +02:00
Jean Paul Galea
29deb6007d Removed dead code. 2015-07-16 14:26:14 +02:00
Jean Paul Galea
514b943945 Cosmetic changes. 
- remove last remaining tabs,
	so now the whole file is using the same indentation convention.
 2015-07-15 17:52:26 +02:00
Jean Paul Galea
2cc0f50257 Cosmetic changes. 
- make it easier to read,
	even though we have a couple of long lines now...
 2015-07-15 17:08:44 +02:00
Jean Paul Galea
dfdc4610d6 Refactor. 
- make it easier to follow what is happenining in queue().
 2015-07-15 17:01:51 +02:00
Jean Paul Galea
d5a56f6b8c Refactor updateDbCounters. 
- make it easier to follow what is happening.
 2015-07-15 16:46:45 +02:00
Jean Paul Galea
3b4735d34d Cosmetic changes. 2015-07-15 16:46:06 +02:00
Jean Paul Galea
6f74d8336b Refactor. 
- removed unnecessary else,
	always return at end of function.
 2015-07-15 16:24:04 +02:00
Jean Paul Galea
edf7ad632d Cosmetic changes. 
- use spaces where possible.
 2015-07-15 16:15:26 +02:00
Jean Paul Galea
a4a12d2f2d Refactor. 
- remove wrapper which provides no help,
	just makes it harder to follow the code.
 2015-07-15 15:44:29 +02:00
Jean Paul Galea
e76c5002f2 Drop php closing tags. 2015-07-15 15:14:25 +02:00
Jean Paul Galea
642c2a79d5 Reduce argument passing. 
- set curlopts directly in wrapper invocation.
 2015-04-14 09:26:56 +02:00
Jean Paul Galea
9d9875c39d Set __YKVAL_SYNC_CURL_OPTS__ for resync requests. 
- Ensure sync/resync requests set the same curl options.

- This changes a debug message from "url is " to
	"YK-VAL resync adding URL: "

- curlopts is now a property of SyncLib class.
	Removes duplication between sync/resync code.
 2015-04-14 09:20:38 +02:00
Jean Paul Galea
8df329aa0e Allowed certain cURL options to be configurable. 
- When calling either URLs in the sync pool or the KSMs,
    the following curl options are configurable;

    CURLOPT_PROTOCOLS
    CURLOPT_IPRESOLVE
    CURLOPT_SSLVERSION
    CURLOPT_SSL_VERIFYPEER
    CURLOPT_SSL_VERIFYHOST
    CURLOPT_CAINFO
    CURLOPT_CAPATH
 2015-04-13 17:42:13 +02:00
Simon Josefsson
92297d3c4d Drop log level of useless messages. 2014-09-24 13:05:09 +02:00
Klas Lindfors
ecd49aca59 change wiki links 2014-09-23 10:36:39 +02:00
Klas Lindfors
02d3090bf8 move some logging in reSync() to LOG_DEBUG 
this is only run from ykval-queue
fixes #24
 2014-09-23 10:27:44 +02:00
Klas Lindfors
2424d153ce always verify ssl peer 
fixes #15
 2014-01-07 12:38:10 +01:00
Dain Nilsson
ee1f040b00 Updated copyright headers. 2013-02-04 17:39:36 +01:00
Dain Nilsson
ad88ccdb1f Updated references to old Google Code project. 2013-02-04 17:06:32 +01:00
Klas Lindfors
34706698a4 Merge branch 'master' into feature/oracle_support 
Conflicts:
	ykval-db.php
	ykval-export.php
	ykval-synclib.php
 2012-06-29 10:33:41 +02:00
Remi Mollon
f9e1a3a883 getRowValue is not needed anymore 2012-06-28 14:55:00 +02:00
Fredrik Thulin
b8d18af10c Remove now unused retrieveURLasync_old() 2012-06-14 15:22:38 +02:00
Fredrik Thulin
c8e9eb828f Pass logger object to retrieveURLasync() 2012-06-14 15:19:04 +02:00
Fredrik Thulin
46180c9de9 Merge branch 'master' of github.com:Yubico/yubikey-val-server-php into devel/refactor_retrieveURLasync 2012-06-14 15:00:47 +02:00
Fredrik Thulin
32c94e9256 Use retrieveURLasync in ykval-common instead. 2012-06-14 14:55:07 +02:00
Klas Lindfors
d37c41011a if the remote sync site says BAD_OTP log and remove from queue 2012-06-14 13:52:53 +02:00
Fredrik Thulin
605abc8cbf delete-trailing-whitespace 2012-06-13 13:41:12 +02:00
Fredrik Thulin
2a7a6e3503 Don't LOG_NOTICE when remote server has seen latest OTP too. 
This is an expected condition for many (most) validation requests
using the asynchronous validation protocol 2.0.
 2012-06-13 13:23:55 +02:00
Fredrik Thulin
afb42d7c0a Logging improvements. 2012-06-13 13:22:35 +02:00
Klas Lindfors
40b5949f44 Merge branch 'master' into feature/oracle_support 2012-06-13 09:55:59 +02:00
Klas Lindfors
3f17b7bdc1 and { is needed. 2012-06-13 09:00:39 +02:00