rooty/yubikey-val
1
0
Fork 0
mirror of https://github.com/Yubico/yubikey-val.git synced 2025-02-01 19:52:20 +01:00
Code Issues Projects Releases Wiki Activity
743 Commits 7 Branches 44 Tags
Commit Graph

743 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jean Paul Galea
c0048ce7cc Add FIXME markers. 2015-07-20 19:56:43 +00:00
Jean Paul Galea
5ed2f1d4d5 Refactor. 
- negate test and return early.

- avoid wrapping whole function in `if () { }`.

- move $condition below $arr,
	since $arr is passwed first, then $condition, to conditionalUpdateBy().
 2015-07-20 19:53:45 +00:00
Jean Paul Galea
3097d13629 Refactor. 2015-07-20 19:44:56 +00:00
Jean Paul Galea
c52300ab39 Improve documentation. 2015-07-20 19:39:59 +00:00
Jean Paul Galea
4ca6fb5448 Refactor database configuration. 
- don't repeat config-db.php file path

- add @is_readable,
	we might not have the proper permissions.

- use 'require_once' instead of 'include',
	this file should only be included once and we
	should fail dramatically if we can't load it.

- better documentation.
 2015-07-20 19:20:04 +00:00
Jean Paul Galea
7e76f9bff8 Cosmetic changes. 
\# -> //
 2015-07-20 19:09:38 +00:00
Jean Paul Galea
1dab5c64aa Cosmetic changes. 2015-07-20 19:04:57 +00:00
Jean Paul Galea
f9fd53046a Move comment where applicable. 2015-07-20 19:04:36 +00:00
Jean Paul Galea
f99776b700 Cosmetic changes. 2015-07-20 18:59:16 +00:00
Jean Paul Galea
be529e2224 Remove unused variables. 
- will add db host/port later, currently they are ignored even if configured.
 2015-07-20 18:58:03 +00:00
Jean Paul Galea
5766518b93 Use TLS for man page www.yubico.com links. 2015-07-20 18:55:46 +00:00
Jean Paul Galea
182b6f326b Use TLS in ykval-config.php examples 2015-07-20 18:51:40 +00:00
Jean Paul Galea
16d8dfe6ac Refactor counter logic. 
- break up into multiple if comparisons.
 2015-07-18 00:46:17 +02:00
Jean Paul Galea
6038c17025 Single quotes. 2015-07-18 00:37:21 +02:00
Jean Paul Galea
b4b44c4d04 Added helper comments. 2015-07-18 00:34:42 +02:00
Jean Paul Galea
7689fe4ba1 Cosmetic changes. 
- method grouping.
 2015-07-18 00:30:31 +02:00
Jean Paul Galea
0e6fe1e1e8 Change scope on private methods. 
- mainly to help refactor,
	and avoid grep'ing globally.
 2015-07-18 00:26:24 +02:00
Jean Paul Galea
c94f0d03a1 Refactor. 
- getClientData() returns array or bool false on failure.
 2015-07-18 00:19:04 +02:00
Jean Paul Galea
635981f3d3 Set scopes on methods. 
- confirmed to be used publically.
 2015-07-18 00:16:03 +02:00
Jean Paul Galea
ef8a8640c7 FIXME markers. 2015-07-18 00:09:19 +02:00
Jean Paul Galea
db0f55b818 Fix. 
- fix bug introduced in a28ad6df698b4ef20b6698a1f993019ad25bef25.
 2015-07-18 00:07:22 +02:00
Jean Paul Galea
b3c5ecc724 Refactor. 
- use single quotes where possible.
 2015-07-18 00:05:32 +02:00
Jean Paul Galea
39ce50b772 Cosmetic changes. 2015-07-17 23:59:26 +02:00
Jean Paul Galea
23474aec31 Cosmetic changes. 2015-07-17 23:55:44 +02:00
Jean Paul Galea
ba160c9976 FIXME marker. 
- probably should be '&local_counter' not ',local_counter'.

- check later as this is written to db and if we fix here,
	we might break other stuff.
 2015-07-17 23:48:56 +02:00
Jean Paul Galea
47422f9c70 Cosmetic changes. 2015-07-17 23:46:54 +02:00
Jean Paul Galea
c865edcc15 Cosmetic changes. 2015-07-17 23:41:44 +02:00
Jean Paul Galea
645c5c5467 Fix bug. 
- this was not introduced by my refactoring.

- LOG_ALERT message was incorrect,
	probably yy,p from counter block.
 2015-07-17 23:38:17 +02:00
Jean Paul Galea
3aecc617c3 Fix bug. 
- this was not introduced by my refactoring.

- LOG_ALERT for; yk_low, yk_high, nonce was written only
	if yk_use failed to be parsed.

- as a result, this commit might change LOG_ALERT output.
 2015-07-17 23:35:15 +02:00
Jean Paul Galea
a0f57bd674 Cosmetic changes. 2015-07-17 23:33:29 +02:00
Jean Paul Galea
be4ee3116e Cosmetic changes. 2015-07-17 23:30:57 +02:00
Jean Paul Galea
60d1e7e302 Refactor away useless else { } wrap. 2015-07-17 23:27:43 +02:00
Jean Paul Galea
9869bfe84d Cosmetic changes. 2015-07-17 23:25:52 +02:00
Jean Paul Galea
afc81e484a Refactor away useless variable. 2015-07-17 23:22:27 +02:00
Jean Paul Galea
a20b0b69ae Cosmetic changes. 2015-07-17 23:21:22 +02:00
Jean Paul Galea
acfafc5d72 Refactor. 
- be explicit and declare as public,
	since we're clearly using it.
 2015-07-17 23:17:37 +02:00
Jean Paul Galea
ed169f49c5 Refactor. 
- getLocalParams() returns array or bool false on failure.
 2015-07-17 23:17:28 +02:00
Jean Paul Galea
e604477fff Refactor. 
- str sub instead of concat.
 2015-07-17 23:11:32 +02:00
Jean Paul Galea
2b434df808 Refactor. 
- removed duplicate variable.
 2015-07-17 23:10:27 +02:00
Jean Paul Galea
5a272cf928 Refactor. 
- remove unnecessary else { } wrap.
 2015-07-17 23:07:17 +02:00
Jean Paul Galea
fd5391bb91 Cosmetic changes. 2015-07-17 23:06:21 +02:00
Jean Paul Galea
a0de5b9fd5 Refactor. 
- str sub instead of concat
 2015-07-17 23:03:40 +02:00
Jean Paul Galea
8991c2c0c4 Cosmetic changes. 2015-07-17 23:01:36 +02:00
Jean Paul Galea
1e2568da3c Refactor. 
- KSMDecryptOTP returns array or bool false on failure.
 2015-07-17 22:55:23 +02:00
Jean Paul Galea
9e81b1fd72 Refactor. 
- minor improvements.

- move $ret init right before it's used.

- use string substitution rather than concatenation.
 2015-07-17 22:51:11 +02:00
Jean Paul Galea
ef6adeb826 Cosmetic changes. 
- adhere with some form of convetion for comments.

- use single quotes where possible.
 2015-07-17 22:48:35 +02:00
Jean Paul Galea
13530c532f Cosmetic changes. 2015-07-17 22:38:43 +02:00
Jean Paul Galea
c5b6b3c567 Refactor. 
- retrieveURLasync() always returns FALSE on failure now,
	before it might have returned a string.

- use array_shift($a) to pop first element,
	safer than $a[0];

- this commit might affect what is written to LOG_DEBUG,
	since now we only write the YK-KSM message when we
	are certain to have a valid response.
 2015-07-17 22:25:42 +02:00
Jean Paul Galea
60a487a996 Cosmetic changes. 2015-07-17 22:12:59 +02:00
Jean Paul Galea
107995fc24 Refactor. 
- remove counter and use count($array) instead.
 2015-07-17 22:06:13 +02:00