rooty/yubikey-val
1
0
Fork 0
mirror of https://github.com/Yubico/yubikey-val.git synced 2024-11-29 00:24:13 +01:00
Code Issues Projects Releases Wiki Activity
731 Commits 7 Branches 44 Tags 1.1 MiB
b106789217
Commit Graph

106 Commits

Author SHA1 Message Date
Jean Paul Galea
b106789217 Fix. 
- fix bug introduced in 6181abee14.

- essentially, strftime() uses different format than date()
 2015-07-24 14:50:02 +02:00
Jean Paul Galea
9704cf7ae1 Refactor. 
- avoid unnecessary strtotime() call.

- instead of:
		strtotime(date('Y-m-d H:i:s', $timestamp))

	use:
		$timestamp

	since:
		$timestamp === strtotime(date('Y-m-d H:i:s', $timestamp))
 2015-07-24 14:45:41 +02:00
Jean Paul Galea
6181abee14 Refactor. 
- strftime -> date.

- strftime is same as date, but with locales.

- date format doesn't output names (January, March, etc.),
	so locale doesn't matter.

- also, would we really want locale in logs?
 2015-07-24 14:35:30 +02:00
Jean Paul Galea
342ceac544 Modify log write. 
- Log::log() internally support array implode,
	so no need to duplicate functionality.

- however, the internal implode uses two consecutive spaces as separator,
	so this will change the log format slightly.

	e.g. "delta=x now=y" becomes "delta=x  now=y"
 2015-07-24 14:01:22 +02:00
Jean Paul Galea
c05a505b9c Refactor. 2015-07-24 13:54:49 +02:00
Jean Paul Galea
a6ad2e7d4b Cosmetic changes. 2015-07-24 10:55:34 +02:00
Jean Paul Galea
231c1ad0c5 Refactor. 2015-07-24 10:54:21 +02:00
Jean Paul Galea
1341227342 Refactor. 2015-07-24 10:50:21 +02:00
Jean Paul Galea
424fbdf962 FIXME markers. 2015-07-21 21:45:07 +00:00
Jean Paul Galea
da689f7de4 Cosmetic changes. 2015-07-21 21:38:46 +00:00
Jean Paul Galea
3572410b30 Better grouping. 
- same as 1e799aa6e5.

- group $timeout filtering and validation.

- this commit might change replies sent to clients,
	since the validation check is done eaerlier now,
	and we might return S_MISSING_PARAM before S_BAD_OTP for example.

- this should really not cause any issues though,
	the order of which error is raised first should not matter to clients.
 2015-07-21 21:27:33 +00:00
Jean Paul Galea
1e799aa6e5 Better grouping. 
- group $sl filtering and validation.

- this commit might change replies sent to clients,
	since the validation check is done eaerlier now,
	and we might return S_MISSING_PARAM before S_BAD_OTP for example.

- this should really not cause any issues though,
	the order of which error is raised first should not matter to clients.
 2015-07-21 21:17:59 +00:00
Jean Paul Galea
1e4453ccdf Refactor and unset after use. 2015-07-21 21:12:21 +00:00
Jean Paul Galea
82d5796245 Refactor. 2015-07-21 21:09:17 +00:00
Jean Paul Galea
262671f50b Refactor. 
- single quotes.

- unset after use.

- don't wrap.
 2015-07-21 21:05:16 +00:00
Jean Paul Galea
847f288cf5 Refactor. 2015-07-21 21:03:03 +00:00
Jean Paul Galea
11c160b05c Cosmetic changes. 2015-07-21 21:02:50 +00:00
Jean Paul Galea
e5238b8f54 Refactor. 
- only add nonce to $extra array after check.
 2015-07-21 20:56:02 +00:00
Jean Paul Galea
e24b02a7dc Refactor. 
- $new_otp not used afterwards,
	clean up to avoid reuse by mistake.
 2015-07-21 20:54:49 +00:00
Jean Paul Galea
84e867a6eb Better grouping. 
- no functional affect whatsoever.
 2015-07-21 20:53:13 +00:00
Jean Paul Galea
0749db6e8f More robust https check. 2015-07-21 20:49:17 +00:00
Jean Paul Galea
c5983f13eb Refactor. 2015-07-21 20:45:57 +00:00
Jean Paul Galea
06d037ef09 Refactor. 2015-07-21 20:44:53 +00:00
Jean Paul Galea
937dd1a674 Refactor. 
- avoid using $_SERVER vars in "core",
	helps when debugging or running via cli.
 2015-07-21 20:38:57 +00:00
Jean Paul Galea
3414c15eb4 Unwrap else block. 
- sendResp calls exit()
 2015-07-21 20:26:55 +00:00
Jean Paul Galea
1ca175ef2e More minor fixes. 2015-07-21 20:26:37 +00:00
Jean Paul Galea
116d992da2 Refactor. 
- $apiKey is initiliased further down.
 2015-07-21 20:13:17 +00:00
Jean Paul Galea
b24eabeac4 Refactor. 
- str substitution rather than concat.

- cosmetic changes.
 2015-07-21 20:12:05 +00:00
Jean Paul Galea
7686afc4a7 double -> single quotes. 2015-07-21 20:01:24 +00:00
Jean Paul Galea
b417759932 Update copyright year. 2015-07-20 20:01:16 +00:00
Jean Paul Galea
c94f0d03a1 Refactor. 
- getClientData() returns array or bool false on failure.
 2015-07-18 00:19:04 +02:00
Jean Paul Galea
ef8a8640c7 FIXME markers. 2015-07-18 00:09:19 +02:00
Jean Paul Galea
ed169f49c5 Refactor. 
- getLocalParams() returns array or bool false on failure.
 2015-07-17 23:17:28 +02:00
Jean Paul Galea
e604477fff Refactor. 
- str sub instead of concat.
 2015-07-17 23:11:32 +02:00
Jean Paul Galea
2b434df808 Refactor. 
- removed duplicate variable.
 2015-07-17 23:10:27 +02:00
Jean Paul Galea
8991c2c0c4 Cosmetic changes. 2015-07-17 23:01:36 +02:00
Jean Paul Galea
1e2568da3c Refactor. 
- KSMDecryptOTP returns array or bool false on failure.
 2015-07-17 22:55:23 +02:00
Jean Paul Galea
8edf9ba465 Cosmetic changes. 2015-07-17 21:32:09 +02:00
Jean Paul Galea
ac3b4978b8 Cosmetic changes. 2015-07-17 21:30:30 +02:00
Jean Paul Galea
d9194c854d Cosmetic changes. 2015-07-17 21:25:15 +02:00
Jean Paul Galea
a66322754d Cosmetic changes. 2015-07-17 21:23:00 +02:00
Jean Paul Galea
2170247166 Cosmetic changes. 2015-07-17 21:20:14 +02:00
Jean Paul Galea
38c048b833 Cosmetic changes. 2015-07-17 21:17:29 +02:00
Jean Paul Galea
be27f62236 Cosmetic changes. 2015-07-17 21:16:40 +02:00
Jean Paul Galea
291bd32bae Refactor. 
- after each sendResp() we had an exit;

- move exit; inside sendResp() function instead.
 2015-07-16 22:47:16 +02:00
Jean Paul Galea
bc5319327b Unwrap function. 2015-07-16 22:35:34 +02:00
Jean Paul Galea
6e4b89048e Refactor. 
- better grouping for validation.
 2015-07-16 15:39:42 +02:00
Jean Paul Galea
e76c5002f2 Drop php closing tags. 2015-07-15 15:14:25 +02:00
Jean Paul Galea
8df329aa0e Allowed certain cURL options to be configurable. 
- When calling either URLs in the sync pool or the KSMs,
    the following curl options are configurable;

    CURLOPT_PROTOCOLS
    CURLOPT_IPRESOLVE
    CURLOPT_SSLVERSION
    CURLOPT_SSL_VERIFYPEER
    CURLOPT_SSL_VERIFYHOST
    CURLOPT_CAINFO
    CURLOPT_CAPATH
 2015-04-13 17:42:13 +02:00
Dain Nilsson
1b2dfd136c Use constant time string comparisson for validating HMAC signature 
(fixes #26).
 2014-09-27 15:47:57 +02:00