- avoid having to use the same internal and label name,
as it's problematic.
- internal name has a lot of restrictions:
s/^[^A-Za-z_]/_/
s/[^A-Za-z0-9_]/_/g
- which doesn't allow us to show proper label names,
the names that users will see.
- label displays :80 or :443 depending on scheme.
- avoid ugliness with shortname() and instead use endpoints().
- use hostname (+ port if any) for graph name.
i.e. if we have a sync URL:
https://api.yubico.com:8080/wsapi/2.0/sync
instead of having "api" as name,
we have "api.yubico.com:8080".
- also avoid using regex and use parse_url() from php core instead.
- plugin assumed URL uses a hostname (no static ips)
and that hostname resolves to both ipv4 and ipv6.
- if we want to differentiate stats between ipv4 and ipv6,
we need to re-think this and do it in a smart way.
- for now we prefer to allow cURL to pick whatever IP it resolves,
and run the latency test on that.
- signed off by Klas Lindfors.
- use PATH_SEPARATOR everywhere,
instead of a mix of PATH_SEPARATOR and hard coded colons.
- always include /usr/share/yubikey-val first,
then /etc/yubico/val.
- should not have any visible affects,
since no file names are common between the two directories.
- use array+implode to make it easier to add/remove paths,
and to avoid hardcoded the path separator.
- don't depend on external binaries,
it assumes too much and is dangerous.
- we can depend on libcurl instead,
since it's already a dependency in core.
- we should do this for other plugins too,
and move the new function into ykval-common.php
- plugin reports same exact values as before.
