Patrick H. Lauke
3aa3fda730
Carousel: use buttons, not links, for prev/next controls ( #32627 )
...
* Carousel: use buttons, not links, for prev/next
- expand the styles to neutralise border/background
- change docs page
- add extra unit test to check that links or buttons work as controls
- modify visual test to use buttons as well
- use buttons instead of links for prev/next
- remove `role="button"` from links that are actually links
* Clarify that controls can be button or link
* Update site/content/docs/5.0/components/carousel.md
Co-authored-by: Mark Otto <markd.otto@gmail.com>
* Explicitly set padding to 0 to prevent dipping/moving on active in Firefox
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-27 17:31:16 +02:00
Rohit Sharma
c9cd741aff
Throw a TypeError
instead of the generic Error
( #32585 )
...
* Change from Error to TypeError
* Convert the `NAME` to upper case to make the consistency in the error message
* Update the remaining tests to be stricter
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-13 22:13:30 +02:00
Rohit Sharma
e34481b6eb
Fix toggling modal when clicking on data-bs-toggle="modal"
( #32691 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-13 21:59:47 +02:00
XhmikosR
cad88abdb0
JS: update karma config ( #32769 )
...
* rename constants
* enforce the constants to be Boolean
* fix karma `logLevel`
2021-01-13 19:16:51 +02:00
Théophile Helleboid - chtitux
80557b3ac0
Move "active" class from .nav-item
to .nav-link
( #32730 )
2021-01-08 20:53:04 +02:00
Daniele Faraglia
59cd71631e
collapse: prevent url change if A
nested tag is clicked ( #32438 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-21 14:37:35 +02:00
Nils K
2d46e47464
Support Popper virtual elements ( #32376 )
...
Adds the ability to use objects implementing the virtual element interface as the value for the reference option of a dropdown config.
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-21 14:32:11 +02:00
Gaël Poupard
58ab1c2cd5
test(carousel): french word in the wild ( #32528 )
2020-12-18 17:22:16 +02:00
dependabot[bot]
66f323af70
Bump eslint-plugin-unicorn from 23.0.0 to 24.0.0 ( #32516 )
...
* Bump eslint-plugin-unicorn from 23.0.0 to 24.0.0
Bumps [eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn ) from 23.0.0 to 24.0.0.
- [Release notes](https://github.com/sindresorhus/eslint-plugin-unicorn/releases )
- [Commits](https://github.com/sindresorhus/eslint-plugin-unicorn/compare/v23.0.0...v24.0.0 )
Signed-off-by: dependabot[bot] <support@github.com>
* Update karma.conf.js
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-18 15:11:07 +02:00
Rohit Sharma
f12657b39f
tests: replace deprecated jQuery method ( #32309 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-16 17:21:43 +02:00
XhmikosR
29e4eb91c1
BrowserStack: test on macOS Catalina instead of High Sierra ( #32486 )
2020-12-16 12:45:48 +02:00
Rohit Sharma
ebce95dc60
Tooltip - Add missing callback in async spec ( #32465 )
2020-12-14 13:02:34 +02:00
Rohit Sharma
4535b09c46
Tooltip - check if tip and its parent node exist in dispose method ( #32420 )
2020-12-10 21:06:41 +02:00
alpadev
85208ae557
Refactor components to use a utility function to define jQuery plugins ( #32285 )
...
* refactor: use an utility function to define jQuery plugins
* test: add spec for defineJQueryPlugin utility function
* Update .bundlewatch.config.json
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-08 08:16:50 +02:00
XhmikosR
d15a0247ce
Remove SelectorEngine.matches()
. ( #32339 )
...
It's basically unused.
2020-12-07 19:10:20 +02:00
Johann-S
adfdf7160b
Update to popper.js v2.x
2020-12-06 18:42:40 +02:00
Gaël Poupard
9488978fb5
feat(RTL): implement RTL
...
Using RTLCSS directives, renaming things to use logical names and following best practices.
2020-12-04 07:52:03 +02:00
XhmikosR
dd992c7226
Add tests
2020-11-30 12:07:51 +02:00
XhmikosR
51a208f119
Switch to Jasmine's toBeInstanceOf
matcher
2020-11-29 20:58:26 +02:00
Johann-S
9f6b342dc7
create a base component
2020-11-29 20:58:26 +02:00
Rohit Sharma
c348ad4a94
Ability to add custom class in tooltip/popover ( #32217 )
...
Porting of #31834 to main.
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-25 09:16:22 +02:00
XhmikosR
767db7b746
tests/integration/index.html: revert accidental changes
2020-11-23 22:14:52 +02:00
Rohit Sharma
7c7f08b5e0
Update bundle.js in tests/integration ( #32233 )
...
* Use `[].concat` instead of direct spreading nodelist
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-23 21:35:46 +02:00
XhmikosR
f4457bca02
Be consistent with Popper's name. ( #32224 )
...
The npm package is named "popper.js" but the project is named "Popper", so use the latter consistently.
2020-11-21 16:22:08 +02:00
Rohit Sharma
358c36d4b5
Add missing tags in unit tests ( #32221 )
2020-11-20 20:10:15 +02:00
Rohit Sharma
0839cbf04d
Don't hide modal when keyboard is set to false in modal's configuration ( #32179 )
...
* Don't hide modal when config.keyboard is false
* Update unit test
- Modal should not be closed when pressing esc key if keyboard = false
and backdrop is 'static'
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-20 15:36:24 +02:00
Rohit Sharma
2630b05eb3
Make the attribute methods bs specific ( #32173 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-20 11:13:13 +02:00
XhmikosR
2d4f1b272c
Update karma.conf.js ( #32182 )
...
When we are on CI, this statement won't be reached.
2020-11-18 13:06:04 +02:00
Gaël Poupard
1955ffc01e
Handle Chromium to run Karma ( #32178 )
...
* chore(karma): handle Chromium to run tests
* Update karma.conf.js
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-17 21:42:55 +02:00
XhmikosR
60c79b28aa
BrowserStack: test both on iPhone 7 and iPhone X ( #32154 )
2020-11-16 14:31:03 +02:00
XhmikosR
2e758f64cf
Switch to Number properties
2020-11-14 15:54:50 +02:00
XhmikosR
4f8b243ac1
Fix .close
instances ( #32152 )
2020-11-14 08:16:30 +02:00
Rohit Sharma
e530118117
Get only bs prefixed data attributes
2020-11-14 07:09:15 +02:00
Rohit Sharma
418f17ee2b
Add bs
in data attributes
...
- Add `bs` in data APIs everywhere
- Update unit tests
2020-11-14 07:09:15 +02:00
XhmikosR
411fc649f2
modal.html: use textContent
( #32101 )
...
We are not handling any HTML
2020-11-09 20:47:33 +02:00
XhmikosR
c0d1ed57a3
karma.conf.js: break lines ( #32093 )
2020-11-09 20:33:20 +02:00
XhmikosR
13572a6867
Remove the now unneeded polyfills.
2020-11-05 15:37:34 +02:00
XhmikosR
e8f1709adf
Drop Legacy Edge support.
...
This allows us to move forward without being held back. Microsoft already replaces the Legacy Edge with the new one on supported Windows versions.
2020-11-05 15:37:34 +02:00
XhmikosR
c9f8fa45fb
tests: tweak Jasmine usage ( #32046 )
...
* jasmine/expect-matcher
* jasmine/prefer-jasmine-matcher
Found with `eslint-plugin-jasmine`
2020-11-02 16:13:24 +02:00
XhmikosR
e2697b0573
tests: fix sanitizer test. ( #32045 )
...
The test template does not include a `script` tag so the test always returned true.
2020-11-02 14:49:56 +02:00
XhmikosR
71010cb1e9
tests: switch to using toContain()
to check for substring presence ( #32043 )
2020-11-02 14:42:40 +02:00
XhmikosR
59692ce862
karma: stop excluding polyfill.js from istanbul ( #30740 )
2020-11-01 15:52:24 +02:00
Sascha
c21506d499
Fix TypeError when Bootstrap is included in head
( #32024 )
...
* extend jquery after domContentLoaded event is fired
* add unittest for util onDOMContentLoaded
* wait for trigger jquery event after domContentLoaded
* remove domcontentready from eventHandler
* move istanbul ignore statements to correct line
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-01 15:32:36 +02:00
Mitchell Bryson
3a5f9f5cf0
Check for data-interval on the first slide of carousel ( #31818 )
...
* check for data-interval on the first slide of carousel
* add updateInterval method for elements of a carousel
* add test for carousel interval being set during cycle
* update activeElement as soon as slide has finished (before transition end)
* only updateInterval before using it
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-01 14:36:50 +02:00
XhmikosR
b63066d630
toast.spec.js: fix typo ( #32026 )
2020-10-31 09:25:33 +02:00
XhmikosR
c196d21e7f
Remove obsolete prefixes ( #32012 )
2020-10-30 07:29:48 +02:00
XhmikosR
5a3f273b60
Move href
attribute first ( #31835 )
2020-10-22 09:38:15 +03:00
Patrick H. Lauke
836a4c0bd6
Remove redundant visually hidden "(current)" from pagination controls ( #31892 )
...
* Replace visually hidden span with aria-current in tests
* Remove redundant visually hidden "(current)" when `aria-current` already used
Closes #31891
2020-10-14 11:59:43 +01:00
XhmikosR
0c1651ee9d
Remove Manipulator.toggleClass
( #31842 )
...
It's only used in one place so it makes more sense to remove it for the time being.
2020-10-05 18:07:49 +03:00
Hiws
43b4252a34
fix tooltip hide method when already hidden ( #31115 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-09-24 14:55:38 +03:00
Rohit Sharma
f6348f6c89
Clear timeout before showing the toast ( #31155 )
...
* clear timeout before showing the toast
* Add unit test
* Remove the check for timeout
* Check for clearTimeout to have been called
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-07-11 11:51:04 -07:00
XhmikosR
bd72dfc41d
Update to @rollup/plugin-node-resolve
v8.1.0. ( #31249 )
2020-07-07 10:23:11 +03:00
Patrick H. Lauke
10690dd317
Rename sr-only
/sr-only-focusable
( #31139 )
...
* Rename `sr-only`/`sr-only-focusable`
To be more representative of the fact that these are not necessarily "screen reader" specific, but actually apply to assistive technologies in general (and also things like Alexa/Siri/etc). Goes hand-in-hand with #31133
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-07-03 14:38:11 +03:00
XhmikosR
786208ea15
BrowserStack: stop testing on latest Edge. ( #31125 )
...
It's Chromium-based so it seems redundant.
2020-06-25 11:42:55 +03:00
Shohei Yoshida
fb4efb49ea
Prevent overflowing static backdrop modal animation ( #30326 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-06-25 11:35:53 +03:00
Patrick H. Lauke
edbcc401c2
Change whitelist to allowlist ( #31066 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markd.otto@gmail.com>
2020-06-19 11:31:37 +03:00
Tanguy Krotoff
d80a9fc553
Fix tooltip when hovering a children element (delegateTarget) ( #30928 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-06-18 10:02:44 +03:00
Johann-S
088c727a31
data: reword storage key in dom
2020-06-17 15:45:36 +02:00
XhmikosR
c28934cb18
Rename "master" to "main". ( #31050 )
2020-06-16 21:41:47 +03:00
XhmikosR
3b66bbeddc
Fix a broken link and a redirect. ( #31045 )
2020-06-16 19:32:00 +03:00
Martijn Cuppens
1a0a0858ef
Remove checkbox/radio toggle from button plugin in favor of a CSS only solution
2020-06-15 19:04:19 -07:00
Rohit Sharma
e140ff92ed
Remove .nav-item from .nav-link to make it consistent
...
- Closes #28423
2020-06-09 07:48:58 +03:00
Rohit Sharma
5faf41eb48
Add role="dialog" in modals via JavaScript ( #30936 )
2020-06-04 10:35:09 +03:00
XhmikosR
340236cbe4
Update to @rollup/plugin-babel
( #30742 )
2020-05-26 06:14:12 +03:00
Mark Otto
d2f07ec9e1
Fix some easy Markdown linting issues
...
- Always use dashes for bullets
- Add some basic alt text for our readme OC sponsors
2020-05-18 16:28:22 +03:00
XhmikosR
fbdacc0e92
coverage: ignore node_modules
2020-05-12 08:31:38 +03:00
Dominik Kremer
d59de33fc0
Add a test about the scrollbar issue on non-integer width
2020-05-12 07:51:09 +03:00
XhmikosR
94109cabf4
Add missing closing div
tags ( #30775 )
...
Missed those in 967e607
2020-05-11 16:54:56 +03:00
Rohit Sharma
ec3cfae29c
Removed role="document" from the modal dialog ( #30755 )
2020-05-11 12:45:42 +03:00
XhmikosR
967e6071ba
tests: streamline HTML end tags ( #30648 )
2020-05-06 09:20:08 +03:00
Johann-S
650a7a7b76
add unit tests to ensure our plugins works in jquery
2020-05-06 07:55:48 +02:00
XhmikosR
122c99ebeb
BrowserStack: test Edge 16 too ( #30725 )
2020-05-05 22:10:16 +03:00
XhmikosR
345fd1fe4c
Revert "Update karma.conf.js"
...
This reverts commit b8abded0af
.
2020-05-05 17:34:48 +03:00
XhmikosR
db80eb96fa
Move babel whitelist helpers to a common file ( #30723 )
2020-05-04 20:08:28 +03:00
XhmikosR
b8abded0af
Update karma.conf.js
...
Use the recommended karma-browserstack-launcher settings
2020-05-04 20:01:29 +03:00
XhmikosR
37f2c04c5f
Clean up lint rules ( #30721 )
...
* Remove unneeded rule suppression
* Format tests/unit/.eslintrc.json
* build/.eslintrc.json: add strict for consistency
2020-05-04 19:32:09 +03:00
Tanguy Krotoff
d2ed920b15
Remove caret element ( #30633 )
2020-04-24 21:53:31 +02:00
Tanguy Krotoff
7787f642b9
Fix crash when pressing ArrowUp the first time
2020-04-17 18:22:15 +03:00
Tanguy Krotoff
dcd99aa7d1
Replace event.which with event.key and event.button
2020-04-17 18:22:15 +03:00
ysds
dfa017adc3
Always modal scroll top to 0
2020-04-01 10:05:43 +03:00
Martijn Cuppens
c48d89cb70
Use unordered lists in dropdown-menus
2020-03-31 22:52:57 +02:00
XhmikosR
e1f5d819c7
Remove MSPointerEvent
and ms-touch-action
in tests ( #30463 )
2020-03-29 09:59:54 +03:00
XhmikosR
ed94976ea8
Use textContent
instead of innerText
. ( #30462 )
...
It's supported by all of our supported browsers.
2020-03-29 09:53:57 +03:00
XhmikosR
f761d8e801
Remove holder.js leftovers ( #30469 )
2020-03-28 12:07:14 +02:00
Laussel Loïc
7ce29d75f3
v5 tabs - accessibility issue when using ul/li semantic
...
Add aria-role presentation on li element when ul element has role tablist and remove dropdown from visual tests as they've been removed from doc
2020-03-28 09:51:24 +02:00
Johann-S
fe492d8021
fix babel config in our files
2020-03-25 22:32:37 +02:00
Johann-S
26d86fce2a
fix: remove make array util function ( #30430 )
2020-03-25 16:35:02 +02:00
Martijn Cuppens
2e150e722a
Use next dropdown menu instead of first of the parent
2020-03-23 15:35:07 +01:00
XhmikosR
018a94c9c1
Remove Internet Explorer leftovers
2020-03-18 20:59:27 +02:00
Johann-S
47aef7b2c6
Remove IE compatibility JS code
2020-03-18 20:59:27 +02:00
Johann-S
aff115219e
fix: ensure totype
always returns stringified null/undefined when null/undefined is passed ( #30383 )
2020-03-18 13:10:55 +02:00
Martijn Cuppens
7d8c7c4ba8
prev()
function fails when non-element nodes are present (#30117 )
...
The `prev()` function doesn't take nodes other than elements into account. Also we could simplify things a lot using the `previousElementSibling` property. This property isn't fully supported in IE, it only works for elements, but since the `element` variable is an element, we can safely use it here.
I've also added an additional test.
I don't think we had this issue in v4, since we relied on jQuery back then.
Ref. https://developer.mozilla.org/en-US/docs/Web/API/NonDocumentTypeChildNode/nextElementSibling
2020-03-09 17:21:04 +02:00
yonikohen
7a60dcf9b0
Corrected grammatical error in test descriptions ( #30150 )
...
"without instantiate it" should be "without instantiating it"
2020-02-10 09:35:13 +02:00
Martijn Cuppens
ef6c13c534
tests: Remove button href
s ( #30119 )
2020-02-01 20:39:18 +02:00
Giovanni Mendoza
954a0b1e6a
Close modal with keyboard=true & backdrop=static ( #29986 )
...
* Close modal with keyboard=true & backdrop=static
2020-01-10 11:06:12 +02:00
XhmikosR
8f1c4b9a03
Switch to @rollup/plugin-commonjs ( #29907 )
2019-12-25 21:43:56 +02:00
XhmikosR
f153748f52
Switch to @rollup/plugin-node-resolve ( #29851 )
2019-12-25 21:36:22 +02:00
Steffen Roßkamp
c62efc3ef6
Update normalizeDataKey to match the spec ( #29609 )
2019-10-31 07:58:09 +02:00
Higor Araújo dos Anjos
46912797b2
Added animation when modal backdrop is static ( #29516 )
2019-10-25 21:12:09 +03:00
Jeremy Jackson
c1ee395f80
Skip hidden dropdowns while focusing ( #29523 )
2019-10-17 18:01:44 +03:00
XhmikosR
577bf8b14d
Rename "js/tests/units" to "js/tests/unit". ( #29503 )
2019-10-09 01:27:43 +03:00
Johann-S
e1b82f51e2
add modularity integration test
2019-10-03 09:55:57 +02:00
Johann-S
3d12b541c4
return to the original file structure to avoid breaking modularity
2019-10-03 09:55:57 +02:00
XhmikosR
d06eec372a
Minor lint tweaks. ( #29328 )
2019-08-29 16:20:49 +03:00
Johann-S
dcba526775
remove underscore for static methods
2019-07-29 11:34:12 +02:00
Johann-S
e101ba4989
add polyfill.js in visual tests ( #29116 )
2019-07-24 08:19:47 +03:00
Johann-S
233f3fb1ce
rewrite tab unit tests
2019-07-23 14:23:50 +02:00
Johann-S
e1b5d8471a
use qunit css for our fixture
2019-07-23 14:23:50 +02:00
Johann-S
b7b56cb10a
rewrite scrollspy unit tests
2019-07-23 14:23:50 +02:00
Johann-S
85b70cef3c
rewrite tooltip unit tests
2019-07-23 14:23:50 +02:00
Johann-S
c9e650a56f
rewrite popover unit tests
2019-07-23 14:23:50 +02:00
Johann-S
1ac07a66ce
rewrite modal unit tests
2019-07-23 14:23:50 +02:00
Anton Bershanskiy
e916a9bc03
rewrite toast unit tests
2019-07-23 14:23:50 +02:00
Johann-S
6a59c58480
rewrite dropdown unit tests
2019-07-23 14:23:50 +02:00
Johann-S
0ed1618c06
rewrite collapse unit tests
2019-07-23 14:23:50 +02:00
Johann-S
62730d9afd
rewrite carousel unit tests
2019-07-23 14:23:50 +02:00
Johann-S
891a187059
rewrite button unit tests
2019-07-23 14:23:50 +02:00
Johann-S
c834895fa0
rewrite unit tests for selector engine
2019-07-23 14:23:50 +02:00
Anton Bershanskiy
fe6ba2384a
rewrite manipulator unit tests
2019-07-23 14:23:50 +02:00
Johann-S
c8c2074650
Switch from QUnit to Jasmine.
2019-07-23 14:23:50 +02:00
Kitten King
37703a6fc9
Fix Typos across Bootstrap repository ( #29082 )
2019-07-20 12:53:02 +03:00
Johann-S
18077460aa
updated babel
2019-07-17 15:03:32 +03:00
Patrick H. Lauke
cc49977038
Fix dropdown unit test ( #29037 )
...
swap jQuery's `trigger(...)` with the more verbose native `dispatchEvent(...)`, as the former may not always behave/bubble correctly (observed while trying to write unit tests for keyboard handling of ARIA tab navigation), which may lead to this test passing even though it fails in real usage.
2019-07-14 12:24:27 +03:00
Patrick H. Lauke
f2c63ac729
Port new unit test for dropdown from v4 ( #28913 )
...
Add unit test from #28912 to v5
2019-06-25 14:57:41 +03:00
Patrick H. Lauke
f0f75379f6
Closing dropdown with ESC correctly sets focus to toggle ( #28928 )
...
Just firing the focus event isn't enough ... need to actually call the proper `focus()` method for it to actually do it...
2019-06-19 12:23:41 +03:00
Johann-S
d5752a18ab
toast should allow prevent default for hide and show events
2019-05-16 13:24:29 +02:00
Martijn Cuppens
a827934f13
Documentation tweaks ( #28679 )
...
* Documentation tweaks
* Remove redundant col-12 classes
2019-05-08 19:58:29 +03:00
XhmikosR
438e01b61c
Rename eventHandler
and selectorEngine
files.
2019-05-08 17:26:37 +03:00
Johann-S
dda31bbee6
improve build plugin script to keep file name
2019-05-08 17:26:37 +03:00
XhmikosR
e7657c8bc0
Remove the unicorn/filename-case
rule suppression.
2019-05-08 17:26:37 +03:00
Johann-S
14f53d9baa
fix unit tests for chrome mobile
2019-04-15 13:48:27 +02:00
XhmikosR
105687ac4a
Update eslint config for the new xo rules.
2019-04-10 15:18:57 +03:00
XhmikosR
efb9a7749f
karma.conf.js: switch to CI === true
. ( #28588 )
2019-04-01 17:26:43 +03:00
Johann-S
1752addadf
Reset carousel touch delta x to prevent click transformation in swipe ( #28558 )
2019-03-27 14:37:04 +02:00
Johann-S
ad0f5f153c
fix remove files in our visual tests
2019-03-18 01:11:05 +02:00
Johann-S
08679ac0b5
Add back support for IE 11
2019-03-18 01:11:05 +02:00
XhmikosR
6aa475c82e
Use one-line imports when possible. ( #28467 )
2019-03-13 14:55:53 +02:00
Johann-S
2fd50f98a5
build bootstrap in esm
2019-03-11 17:59:08 +02:00
XhmikosR
5bcd6a29cd
Disable a few rules for now.
2019-03-11 17:01:28 +02:00
XhmikosR
46c037410b
Comply to the new rules.
2019-03-11 17:01:28 +02:00
XhmikosR
44e6abcba5
Switch to eslint-config-xo and eslint-plugin-unicorn.
2019-03-11 17:01:28 +02:00
XhmikosR
d5f9107abb
Remove the now unneeded shrink-to-fit
directive. ( #28314 )
2019-02-27 17:47:41 +02:00
XhmikosR
9cbd041f6b
tests: add tests for plugins version. ( #28366 )
2019-02-27 13:20:25 +02:00
XhmikosR
7933ee3282
karma.conf.js: minor simplification.
2019-02-26 13:04:04 +02:00
Johann-S
497518db1a
remove tests for old jQuery 1.9.x compatibility
2019-02-26 13:04:04 +02:00
Johann-S
8a37045b79
move util in a util folder with the sanitizer
2019-02-26 13:04:04 +02:00
XhmikosR
5ad2121819
Remove DOMContentLoaded. ( #28337 )
...
There's no reason for us to wait here.
2019-02-24 15:42:18 +02:00
XhmikosR
423e4a3811
tests/visual/modal.html: fix close button placement.
2019-02-20 22:05:45 +02:00
Johann-S
764bab2941
remove polyfills which override browsers default
2019-02-20 22:05:45 +02:00
XhmikosR
f0c6b24bd7
4.3.1.
2019-02-20 22:05:45 +02:00
Joshua Wilson
fdbb5db919
minor jQuery.hasclass removal ( #28158 )
2019-02-20 22:05:45 +02:00
Peter Blazejewicz
cbd333185e
Use consistent arrow class ( #28105 )
2019-02-20 22:05:45 +02:00
Johann-S
c096e0e0da
bump to 4.2.1
2019-02-20 22:05:45 +02:00
Johann-S
661db08eeb
rewrite toast plugin without jquery
2019-02-20 22:05:45 +02:00
Johann-S
57d50b2134
Improve manipulator coverage
2019-02-20 22:05:45 +02:00
Alessandro Chitolina
6cfc78f2d9
Remove IE support and button bsChecked hack
2019-02-20 22:05:45 +02:00
Johann-S
a2f1d79045
Refactor util plugin and some tests
2019-02-20 22:05:45 +02:00
Johann-S
c44db783bf
chore(update): bump to 4.1.3
2019-02-20 22:05:45 +02:00
Johann-S
5dcca44fcf
fix(visual-test): remove jquery in them
2019-02-20 22:05:45 +02:00
Johann-S
6b0808354d
fix(unit-test): dropdown, collapse and carousel
2019-02-20 22:05:45 +02:00
Johann-S
a1cc9a6e33
fix(util): increase util coverage
2019-02-20 22:05:45 +02:00
Johann-S
096413a994
fix(selector-engine): increase coverage for selector engine
2019-02-20 22:05:45 +02:00
Johann-S
64591b3722
fix(manipulator): increase coverage for manipulator
2019-02-20 22:05:45 +02:00
Johann-S
4d6e41dea6
refactor(polyfill): a file for polyfills
2019-02-20 22:05:45 +02:00
Johann-S
0b719e065c
fix(data): increase coverage for data
2019-02-20 22:05:45 +02:00
Johann-S
9313446274
fix(event-handler): remove the use of our event handler in unit test
2019-02-20 22:05:45 +02:00
Johann-S
2b78078779
fix(data): do not use data object in our unit tests
2019-02-20 22:05:45 +02:00
Johann-S
7eddee286e
remove old references to jquery and some fixes
2019-02-20 22:05:45 +02:00
Alessandro Chitolina
0263d1742c
rewritten scrollspy without jquery
2019-02-20 22:05:45 +02:00
Johann-S
9744886519
upgrade to v4 stable
2019-02-20 22:05:45 +02:00
Alessandro Chitolina
7f08061eca
rewritten tab without jquery
2019-02-20 22:05:45 +02:00
Johann-S
90261b484c
Dropdown without jQuery
2019-02-20 22:05:45 +02:00
Johann-S
330a29734f
fix chores karma
2019-02-20 22:05:45 +02:00
Johann-S
2ff8ed5cbf
Fix new unit test in popover
2019-02-20 22:05:45 +02:00
Alessandro Chitolina
ec69de4b7e
allow register the same handler for different delegated selectors in eventHandler
2019-02-20 22:05:45 +02:00
Alessandro Chitolina
cc6e130fc1
tooltip without jquery
2019-02-20 22:05:45 +02:00
Johann-S
bcbea02886
fix unit test modal
2019-02-20 22:05:45 +02:00
Johann-S
69e4d4f3ac
Rewrite Collapse without jQuery
2019-02-20 22:05:45 +02:00
Alessandro Chitolina
53ca76ebc0
Workaround for M$ Edge resetting defaultPrevented flag upon dispatchEvent
2019-02-20 22:05:45 +02:00
Alessandro Chitolina
33211eefdf
Rewritten modal without jquery ( #23955 )
...
* Trigger jquery events if available in event handler
* Rewritten modal without jquery
2019-02-20 22:05:45 +02:00
Johann-S
9f9712b98c
Add Manipulator object to add shortcuts for dom manipulations
2019-02-20 22:05:45 +02:00
Johann-S
44f38e4128
Rewrite carousel without jquery
2019-02-20 22:05:45 +02:00
XhmikosR
aba87279fd
button without jquery
2019-02-20 22:05:45 +02:00
Johann-S
2970d14dd9
Remove jQuery from alert.js and add .alert only if jQuery is available
2019-02-20 22:05:45 +02:00
Johann-S
0b16c8c6d9
alert without jquery
2019-02-20 22:05:45 +02:00
Johann-S
fb465c4745
Remove jQuery from Util.js
...
s
2019-02-20 22:05:45 +02:00
Patrick H. Lauke
4b00aa6c4e
Remove incorrect aria-haspopup from dropdown toggles ( #28299 )
...
`aria-haspopup` use requires the use of an ARIA `menu`, `listbox`, `tree`, `grid` or `dialog` (see https://www.w3.org/TR/wai-aria-1.1/#aria-haspopup )
in our use (as generic disclosure widgets), it's incorrect and sets up the wrong assumption/behavior from assistive technologies.
in future, we likely want to change our dropdowns to essentially be like a `dialog` - move focus to it when opened, possibly make it modal so focus is maintained inside it and the rest of the page
is hidden/inert.
but for now, removing the incorrect attribute is probably the quickest, most immediate fix.
2019-02-19 11:25:36 +02:00
Johann-S
7bc4d2e0bc
Add sanitize template option for tooltip/popover plugins.
2019-02-13 08:32:15 +02:00
Johann-S
b54ddfda83
fix modal test to be sure we call getTransitionDurationFromElement
2019-02-06 15:01:13 +01:00
Johann-S
3c49467224
allow to override default toast options ( #28186 )
2019-02-06 15:19:04 +02:00
Johann-S
11880109fc
fix tabs, apply show class only when fade class is present ( #28183 )
2019-02-06 11:12:02 +01:00
Jason Golieb
e44d0475e0
Move dropdown offset function logic into private function. ( #28138 )
2019-02-05 10:31:18 +02:00
Jason Golieb
88a34aacbe
Add support for tooltip offset option to be a function.
2019-02-05 10:24:49 +02:00
Shohei Yoshida
de0bb1e052
Scrollable modal ( #27769 )
2019-01-20 23:28:16 +02:00
Johann-S
842da1ddc3
use absolute path to output lcov file for coveralls ( #28075 )
2019-01-17 11:06:43 +01:00
XhmikosR
3aeda9942d
tests: use jQuery from node_modules. ( #28059 )
2019-01-15 18:01:40 +02:00
Johann-S
d51ee0dcf1
Fix Carousel's touch option to not add touch listeners when set to false ( #28046 )
2019-01-14 18:53:54 +02:00
Johann-S
89a73f100e
carousel should not cycle when there is no data-ride on init ( #27968 )
2019-01-04 18:15:01 +02:00
Johann-S
3bd9fb3649
getSelectorFromElement return null on bad selectors ( #27912 )
2018-12-23 14:30:35 +02:00
Mark Otto
eda851ee76
Prep for v4.2.0 release
...
- Move 4.1 docs to 4.2
- Update versions everywhere to 4.1.3 with release script
- Manually bump the shorthand version in package.json
- Add 4.2 to the versions docs page
- Update some redirects
- Fix tests asset URLs
- Bump Nuget and more
2018-12-21 09:03:29 -08:00
XhmikosR
07b4b5907b
Revert "Remove now unnecessary shrink-to-fit viewport directive ( #27818 )" ( #27855 )
...
This reverts commit af484dc12c
.
2018-12-16 16:39:48 +02:00
Patrick H. Lauke
af484dc12c
Remove now unnecessary shrink-to-fit viewport directive ( #27818 )
...
`shrink-to-fit=no` is not needed anymore - Apple removed the need for it from iOS9.3 onwards
See https://www.scottohara.me/blog/2018/12/11/shrink-to-fit.html and https://github.com/h5bp/html5-boilerplate/issues/2102
2018-12-15 01:05:49 +00:00
Johann-S
af60644d2f
integration test to be sure bootstrap can be bundled
2018-12-14 02:08:18 +02:00
XhmikosR
a074cb66d7
Make use of the package.json version_short
property more.
2018-12-14 00:34:38 +02:00
Mike Vastola
fc15c4c4ce
Change button checkbox/radios to ignore hidden input fields ( #27802 )
2018-12-10 10:40:08 +02:00
Johann-S
fa03289d13
avoid console call in our unit tests ( #27790 )
2018-12-06 10:51:35 +02:00
Patrick H. Lauke
6c00dd08bc
Add aria-modal to modals ( #27780 )
...
Dynamically set/remove `aria-modal="true"` when a modal is shown/hidden
2018-12-05 20:58:09 +02:00
Johann-S
b16127fc10
Allow Tooltips/Popovers to work in shadow DOM
2018-12-05 16:02:59 +01:00
Johann-S
37f74c7070
fix regression about using element for tooltip container option
2018-12-05 10:57:02 +01:00
Johann-S
32ab52ba2e
Add test to make sure we enforce focus on modal ( #27723 )
2018-11-25 18:20:55 +02:00
XhmikosR
2b9af5e38c
Remove holder.js.
2018-11-20 21:31:28 +02:00
Laussel LOïc
dc07e8dca8
Update toast documentation following pull #27155
...
Also remove close button everywhere just let it when autohide is set to false
2018-11-13 08:47:32 +02:00
Johann-S
557d5ac74d
Remove the show delay for our toast plugin
2018-11-13 08:47:32 +02:00
Laussel Loïc
4cac833447
Implement data-dismiss="toast"
to allow user to interact itself with the component ( #27155 )
2018-11-13 08:47:32 +02:00
Johann-S
2f81ab007c
Fix toast documentation page.
2018-11-13 08:47:32 +02:00
Johann-S
16cf76ff1a
Create toast JS plugin, add unit tests.
2018-11-13 08:47:32 +02:00
Johann-S
f7a4b39767
handle detached tooltip when we try to hide a modal
2018-11-02 13:39:58 +01:00
Johann-S
cebdfb9090
fix dispose modal unit test
2018-10-30 16:59:24 +01:00
Andrew Luca
bd2851938a
test(Modal): check if modal is disposed
2018-10-30 16:28:32 +01:00
XhmikosR
02df7cd0d2
Fix util tests on IE 10 ( #27556 )
2018-10-30 15:29:04 +02:00
Martijn Cuppens
5aed968750
Prevent the background to be shown when transitioning
2018-10-30 08:57:02 +02:00
Johann-S
2868f07240
update our coverage required for branches and functions
2018-10-29 14:49:29 +01:00
Johann-S
91f8077ed5
add unit tests for our carousel
2018-10-29 14:49:29 +01:00
Johann-S
2c2d04aba5
add unit test to test tabs can be removed without throwing error
2018-10-29 14:01:03 +01:00
Johann-S
ffc8d507c7
calculate modal transition duration based on modal-dialog element
2018-10-28 23:59:17 +02:00
Andrew Luca
1f1308ba22
test(Modal): reuse _getScrollbarWidth in tests
2018-10-21 17:45:02 +02:00
Johann-S
b1dc6b324c
avoid drag img
2018-10-20 15:32:09 +03:00
patrickhlauke
8883ccb205
Set touch-action to "none"
...
Firefox currently seems extremely fickle - with `pan-y` if fires pointercancel as soon as a touch strays even a pixel or so vertically.
While `touch-action: pan-y` would be ideal (allowing users to scroll the page even when their finger started the scroll on the carousel), this prevents a swipe that isn't perfectly/only horizontal to be recognised by Firefox.
2018-10-20 15:32:09 +03:00
patrickhlauke
7b8f01d839
Use correct touch-action values
...
- my fault, my original advice of using `touch-action: pan-x` is exactly the value we *don't* want to have the browser handle...
2018-10-20 15:32:09 +03:00
Johann-S
735c374e9c
use pointer events if available
2018-10-20 15:32:09 +03:00
Johann-S
c08652cfe8
swipe left/right without hammerjs
2018-10-20 15:32:09 +03:00
Johann-S
caefd70463
Add touch support in our carousel with HammerJS.
2018-10-20 15:32:09 +03:00
galczo5
6cbcd03efb
Add show
and hide
methods to dropdown ( #27370 )
2018-10-20 14:27:51 +03:00
XhmikosR
ea575bc1a7
js/tests/visual: fix popper script.
...
Broken after 787441d
.
2018-10-14 08:17:40 +03:00
XhmikosR
339311ddb5
Fix invalid selectors in tests and examples.
2018-10-14 08:17:40 +03:00
Christopher Morrissey
ea0faadde5
feature(carousel): carousel-item interval ( #26667 )
...
adds the ability to assign data-interval to an individual carousel-item
2018-09-18 15:55:48 +03:00
XhmikosR
787441d4bf
docs: use the bundle dist file.
2018-09-18 12:50:18 +03:00
XhmikosR
0b97d1b0c4
Use https in more places and fix a few redirects.
2018-09-14 18:27:55 +03:00
Johann-S
a689120fd2
throw error when folks try to use a bad selector
2018-09-13 22:13:36 +02:00
Johann-S
9efed82522
refactor karma config in one file
2018-09-13 21:59:37 +02:00
Johann-S
c543f360c9
do not use coverage files on browserstack
2018-09-13 21:59:37 +02:00
Johann-S
6e2a823a44
collapse children with no data-parent
2018-09-10 21:10:00 +02:00
Johann-S
a3e45d8ced
add information about valid selectors ( #27137 )
2018-08-31 21:00:29 +02:00
Johann-S
54d86e6249
move away from sauce labs to browserstack
2018-08-30 22:17:15 +02:00
Johann-S
eab9da5beb
fix(util): use querySelector for ids
2018-08-12 17:01:01 +02:00
Johann-S
6b92321f6a
fix(util): use getElementById when it's possible
2018-08-07 18:49:02 +02:00
Johann-S
d18045210c
fix(tests): visual plugins tests
2018-07-23 17:29:53 -07:00
Mark Otto
0e920ce3f4
Reorganize docs for easier deploys
...
With the current docs directory setup, I'm making too many mistakes and have to manually address path changes and directory moves on deploy. This makes for a frustrating experience developing locally and shipping releases. With this PR, we're basically back to the same setup from v3—duplicating the dist directory into our docs directory. Not the most ideal, but very straightforward for me as the release manager.
2018-07-11 23:30:46 -07:00
Johann-S
283ab30164
fix(modal): fix unit test and resetting style
2018-07-11 11:05:38 +02:00
Catalin Zalog
cb82394fc8
fix(modal): removes .navbar-toggler margin
2018-07-11 11:05:38 +02:00