rooty/LibrePilot
1
0
Fork 0
mirror of https://bitbucket.org/librepilot/librepilot.git synced 2025-02-05 21:52:10 +01:00
Code Issues Releases Activity

OP-1246 removed now uneeded FIXME tag in RadioComBridge

Browse Source
This commit is contained in:
Philippe Renon 2014-03-04 10:02:43 +01:00
parent d37854dceb
commit 7ab38eacb6
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
flight/modules/RadioComBridge/RadioComBridge.c
View File

@ -412,8 +412,8 @@ static void radioRxTask(__attribute__((unused)) void *parameters)
} }
} else if (PIOS_COM_TELEMETRY) { } else if (PIOS_COM_TELEMETRY) {
// Send the data straight to the telemetry port. // Send the data straight to the telemetry port.
// FIXME following call can fail (with -2 error code) if buffer is full // Following call can fail with -2 error code (buffer full) or -3 error code (could not acquire send mutex)
// it is the caller responsibility to retry in such cases... // It is the caller responsibility to retry in such cases...
int32_t ret = -2; int32_t ret = -2;
uint8_t count = 5; uint8_t count = 5;
while (count-- > 0 && ret < -1) { while (count-- > 0 && ret < -1) {
@ -512,8 +512,8 @@ static void serialRxTask(__attribute__((unused)) void *parameters)
if (bytes_to_process > 0) { if (bytes_to_process > 0) {
// Send the data over the radio link. // Send the data over the radio link.
// FIXME following call can fail (with -2 error code) if buffer is full // Following call can fail with -2 error code (buffer full) or -3 error code (could not acquire send mutex)
// it is the caller responsibility to retry in such cases... // It is the caller responsibility to retry in such cases...
int32_t ret = -2; int32_t ret = -2;
uint8_t count = 5; uint8_t count = 5;
while (count-- > 0 && ret < -1) { while (count-- > 0 && ret < -1) {
@ -546,8 +546,8 @@ static int32_t UAVTalkSendHandler(uint8_t *buf, int32_t length)
} }
#endif /* PIOS_INCLUDE_USB */ #endif /* PIOS_INCLUDE_USB */
if (outputPort) { if (outputPort) {
// FIXME following call can fail (with -2 error code) if buffer is full // Following call can fail with -2 error code (buffer full) or -3 error code (could not acquire send mutex)
// it is the caller responsibility to retry in such cases... // It is the caller responsibility to retry in such cases...
ret = -2; ret = -2;
uint8_t count = 5; uint8_t count = 5;
while (count-- > 0 && ret < -1) { while (count-- > 0 && ret < -1) {
@ -576,8 +576,8 @@ static int32_t RadioSendHandler(uint8_t *buf, int32_t length)
// Don't send any data unless the radio port is available. // Don't send any data unless the radio port is available.
if (outputPort && PIOS_COM_Available(outputPort)) { if (outputPort && PIOS_COM_Available(outputPort)) {
// FIXME following call can fail (with -2 error code) if buffer is full // Following call can fail with -2 error code (buffer full) or -3 error code (could not acquire send mutex)
// it is the caller responsibility to retry in such cases... // It is the caller responsibility to retry in such cases...
int32_t ret = -2; int32_t ret = -2;
uint8_t count = 5; uint8_t count = 5;
while (count-- > 0 && ret < -1) { while (count-- > 0 && ret < -1) {