rooty/Qware_core
0
0
Fork 0
Code Issues 6 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

[CORE] Usage of recupCommunity() and recupCommunityByDomain() #44

New Issue
Closed
opened 2020-12-25 17:28:43 +01:00 by Ghost · 3 comments
Ghost commented 2020-12-25 17:28:43 +01:00
Copy Link
Copy Source

Already mentioned in #36. I found a possible enhancement with recupCommunity and recupCommunityByDomain functions. Actually, these 2 functions are object wide declared while it should be better to declare them for the whole platform. The best lace to do it is in the lib_system.php file.

Already mentioned in #36. I found a possible enhancement with recupCommunity and recupCommunityByDomain functions. Actually, these 2 functions are object wide declared while it should be better to declare them for the whole platform. The best lace to do it is in the lib_system.php file.
Ghost added the enhancementmaster labels 2020-12-25 17:28:43 +01:00
Ghost commented 2020-12-25 17:31:48 +01:00
Copy Link
Copy Source

Calls of recupCommunity() and recupCommunityByDomain() are now done by the platform wide function, not by $this->... All old calls recupCommunauty() have been renamed to recupCommunity().

Calls of recupCommunity() and recupCommunityByDomain() are now done by the platform wide function, not by $this->... All old calls recupCommunauty() have been renamed to recupCommunity().
Ghost commented 2020-12-25 17:31:56 +01:00
Copy Link
Copy Source

Fixed.

Fixed.
Ghost added the fixed label 2020-12-25 17:32:01 +01:00
Ghost referenced this issue from a commit 2020-12-25 17:33:04 +01:00
Fixed ticket #44
Ghost commented 2020-12-25 17:33:11 +01:00
Copy Link
Copy Source

Pushed to master

Pushed to master
Ghost closed this issue 2020-12-25 17:33:14 +01:00
Sign in to join this conversation.
master
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 fixed
Issue/request fixed
 help wanted
Need some help
 invalid
Something is wrong
 live
Dépôt de la version de production
 live pull
Source code has been pulled on live
 local commit
Source code has been added and committed on local rpository
 master
Dépôt de la version de développement
 php7_migration
Php7 migration related
 php8_migration
Php8 migration related
 question
More information is needed
 remote push
Source code has been pushed to remote repository
 template
Templates related
 wontfix
This won't be fixed
No labels enhancement fixed master
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Luc Zjarr rooty (Rooty)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rooty/Qware_core#44