1
0
mirror of https://github.com/Yubico/yubico-pam.git synced 2024-12-01 15:24:12 +01:00
Commit Graph

730 Commits

Author SHA1 Message Date
Klas Lindfors
3d24e8fd02
Merge branch 'pr-172' 2018-11-13 09:27:24 +01:00
Stephen Gelman
c8c76fbf4c Add support for LDAP client certificate authentication
This adds support for using a client cert/key to authenticate to an LDAP
server.  It is separate from binding with a username and password and
can either be used alongside it or with an anonymous bind to the server.
2018-11-12 18:28:56 +00:00
Stephen Gelman
fc2dc1a025 Add STARTTLS support for LDAP
This allows connecting to LDAP servers that only listen on port 389 but
use STARTTLS to get a TLS connection
2018-11-12 18:28:56 +00:00
Stephen Gelman
8512e5cee8 Add ldap_bind_as_user support
This allows using the authenticating user's username and password to
bind to the LDAP server.  This is desirable because it allows for
looking up the yubikey attributes without needing to create a service
account.
2018-11-12 18:28:50 +00:00
Klas Lindfors
1fe13aa067
Merge branch 'pr-170' 2018-10-29 08:27:31 +01:00
Tero Paloheimo
2af4dafb55 Add man page building dependencies to README
Some further packages are needed to build the man page so I added them
to the README to other users who are building from source.
2018-10-27 13:57:04 +03:00
Klas Lindfors
3b6378e334
Merge branch 'pr-169' 2018-10-24 15:35:13 +02:00
Tero Paloheimo
9341f3477a Fix compiler warning in pam_test.c
Compiler cannot find the declaration for pm_sm_authenticate and prints
the following warning (split due to long line):
pam_test.c:184:10: warning: implicit declaration of function
‘pam_sm_authenticate’; did you mean ‘pam_authenticate’?
[-Wimplicit-function-declaration]
2018-10-24 16:29:11 +03:00
Klas Lindfors
a9b2057db9
Merge branch 'pr-167' 2018-09-13 21:20:56 +02:00
Björn Wiedenmann
bef666a899 Fix buffer overflow in write_chalresp_state()
Buffer was defined as CR_SALT_SIZE = 32 but number of random bytes
was CR_CHALLENGE_SIZE = 63.
2018-08-15 19:59:38 +02:00
Klas Lindfors
05f74ea8e5
Merge branch 'pr-165' 2018-05-23 10:56:26 +02:00
Klas Lindfors
7419287506
Merge branch 'pr-164' 2018-05-23 10:56:21 +02:00
Karol Babioch
6be87e75af Close file descriptors in case fdopen() fails
This makes sure that file descriptors will be closed, even if the
fdopen() call failes, which was overlooked in some cases beforehand.
Should be not an issue in the real world, but let's be as clean as
possible.
2018-05-22 17:27:21 +02:00
Karol Babioch
eb17d840a6 Fix minor typo 2018-05-22 17:24:24 +02:00
Klas Lindfors
b240534c46
Merge branch 'pr-163' 2018-05-18 12:26:50 +02:00
Karol Babioch
a68d3be1bc Make code C90 compliant
This moves variable declrations to the beginning of a block to be C90-compliant.
2018-05-18 12:22:07 +02:00
Klas Lindfors
13ce1b6f52
Merge branch 'pr-162' 2018-05-18 11:48:14 +02:00
Klas Lindfors
b72fa76113
Merge branch 'pr-156' 2018-05-18 11:47:18 +02:00
Karol Babioch
80e7484aea pam_yubico.c: Check for return codes of snprintf() 2018-05-17 16:31:36 +02:00
Karol Babioch
f77893a11c util.c: Check for return codes of snprintf() 2018-05-17 16:28:22 +02:00
Karol Babioch
2f172e3227 ykpamcfg.c: Check also for negative return code of snprintf() 2018-05-17 16:22:15 +02:00
Karol Babioch
f94095879a pam_yubico.c: Use snprintf() instead of sprintf() 2018-05-17 16:18:53 +02:00
Karol Babioch
0972986164 util.c: Check whether generate_random() was invoked successfully
This evaluates the return code from generate_random() within
write_chalresp_state() and returns immediately in case of an error.

This fixes #161.
2018-05-17 16:09:40 +02:00
Klas Lindfors
3339cd2864
add note about physical security. 2018-05-16 09:13:50 +02:00
Klas Lindfors
38e494cd74
Merge branch 'pr-160' 2018-05-07 08:42:58 +02:00
Karol Babioch
c32ddd9665 Limit action length when parsing arguments
This limits the allowable action length when arguments are parsed to
ACTION_MAX_LEN, since this might be exploited otherwise.
2018-05-04 17:06:59 +02:00
Karol Babioch
89c1622ba2 Use strncpy() instead of strcpy()
Not an issue, just the former is considered good practice.
2018-05-04 17:05:43 +02:00
Karol Babioch
66265a3343 ykpamcfg: Use snprintf() instead of strncpy()
strncpy() is _NOT_ a safe version of strcpy() and it should not be used
(ineffective and dangerous since a NUL termination might be missing).
Instead snprintf() the way to safely construct a string with a given
limit. This commit implements this for the action parsing in ykpamcfg.
2018-05-04 17:05:38 +02:00
Karol Babioch
a7c1d0adfd Check whether fullpath can be constructed correctly
This checks the return code of snprintf() and makes sure that fullpath
actually fits into a buffer of size PATH_MAX. Otherwise, it will output
an error and exit.
2018-05-04 17:05:29 +02:00
Karol Babioch
daad39345d Make use of PATH_MAX for fullpath
Instead of hardcoding the buffer size to 256, using PATH_MAX makes more
sense here, since this can be defined differently on different
platforms. This is not perfect, though, refer to [1] for some details.
In our case it should be good enough.

[1]: https://eklitzke.org/path-max-is-tricky
2018-05-04 17:05:15 +02:00
Karol Babioch
b9aaee97ab Remove double space after periods 2018-05-04 10:45:52 +02:00
Klas Lindfors
fa3833b0a0
Merge branch 'pr-154' 2018-05-03 11:56:54 +02:00
Karol Babioch
320f487265 Spell YubiKey consistently
This makes sure that YubiKey is spelled consistently throughout the project,
since it was spelled in many different ways beforehand.
2018-05-03 10:59:44 +02:00
Klas Lindfors
e0ef089300
Merge branch 'pr-155' 2018-05-03 09:45:39 +02:00
Klas Lindfors
0089f810c7
Merge branch 'pr-153' 2018-05-03 09:45:34 +02:00
Karol Babioch
4427abb932 README: Add Travis build status
This adds a Travis build status badge to the README file, so the current
status can be seen on the GitHub page instantly.
2018-05-02 15:39:02 +02:00
Klas Lindfors
95c6d854a7
travis: add check-doc-dist to test script 2018-05-02 15:28:08 +02:00
Karol Babioch
41e6554c66 Spell system-wide consistently throughout the project 2018-05-02 14:53:14 +02:00
Klas Lindfors
067d451a1e
Merge branch 'pr-152' 2018-05-02 14:38:20 +02:00
Karol Babioch
3ecd8ce267 Revise pam_yubico.8.txt man page
This makes the style of the man page more consistent with terms used
through the project in terms of spelling, etc.
2018-05-02 14:33:57 +02:00
Karol Babioch
67a40dbd2d Revise ykpamcfg.1.txt man page 2018-05-02 14:33:41 +02:00
Klas Lindfors
b86e9a2b42
Merge branch 'pr-151' 2018-05-02 14:04:32 +02:00
Klas Lindfors
0c616bc065
Merge branch 'pr-150' 2018-05-02 14:04:27 +02:00
Karol Babioch
5ad10385df README: Add missing descriptions for undocumented options 2018-05-02 14:01:17 +02:00
Karol Babioch
35407b5d4c Add documentation for cainfo option
This adds documentation about the cainfo parameter to both the README as
well as the man page.
2018-05-02 13:48:32 +02:00
Klas Lindfors
41ff09cda8
Merge branch 'pr-149' 2018-05-02 13:41:47 +02:00
Karol Babioch
44e315cdd8 README: Add a section about chalresp_path
This adds a short section about the chalresp_path option, which was missing
previously from the overview of available options in the README file.
2018-05-02 13:36:18 +02:00
Klas Lindfors
cb62c8c188
Merge branch 'pr-148' 2018-04-26 12:24:49 +02:00
Karol Babioch
bb3e2030eb Fix a couple of typos and spell phrases more consistently
Certain phrases (Challenge-response) were not spelled consistently
throughout the project. This commit adjusts for that and fixes a
couple of typos along the way and uses the base form of verbs in
case of error messages.
2018-04-25 15:22:30 +02:00
Klas Lindfors
03099cdef2
debug: drop extra \n at end of debug output 2018-04-24 08:43:33 +02:00