rooty/yubikey-val
1
0
Fork 0
mirror of https://github.com/Yubico/yubikey-val.git synced 2024-11-29 09:24:12 +01:00
Code Issues Projects Releases Wiki Activity
809 Commits 7 Branches 44 Tags 1.1 MiB
8d3be1f352
Commit Graph

809 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Paul Menzel
8d3be1f352 ykval-config.php: Use *ksm* instead of *kms* 
Avoid confusion and use the correct spelling for the three letter
acronym KSM (Key Storage Module).
 2015-12-08 16:31:53 +01:00
Jean Paul Galea
9e351f69e5 Bump versions. 2015-10-05 09:16:54 +02:00
Jean Paul Galea
45d01d2106 NEWS for 2.33 2015-10-05 09:07:45 +02:00
Jean Paul Galea
c4b20dd105 Added localhost port 80 for ksm service. 
- previously the default config only included port 80.

- this was changed in 382cfc2ab5,
	to avoid issues with yhsm-yubikey-ksm, which defaults to port 8002.

- however, this broke configurations running with yubikey-ksm,
	which defaults to port 80.

- a better approach is to have both projects using the same defaults,
	but for now we'll include both urls instead.

- the ksm decrypt requests happen asynchronously,
	so there should not be any performance degradation.

	(since either one of the urls will timeout)
 2015-09-24 11:19:32 +02:00
Jean Paul Galea
cf3b089fcc Drop some comments. 
- not really helpful, better to just depend on what the code does.
 2015-09-15 19:54:23 +00:00
Jean Paul Galea
d0a8657e84 Avoid variable aliases. 2015-09-15 18:41:51 +00:00
Jean Paul Galea
c46d13da17 Refactor. 
- simplify and avoid using different arrays with same values.

- build $otpParams from $otpinfo as soon as we have ksm result,
	then unset $otpinfo.

- futher down, only use $otpParams and $localParams.
 2015-09-15 18:29:55 +00:00
Jean Paul Galea
8f8b8b8e8c Refactor and modify LOG_INFO message. 
- as a result of this commit,
	key=val are separated with two spaces instead of one.
 2015-09-15 17:37:49 +00:00
Jean Paul Galea
a577d0eb0c Avoid variable aliases. 2015-09-15 17:25:53 +00:00
Jean Paul Galea
28ec07af7f Avoid variable aliases. 2015-09-15 17:24:45 +00:00
Jean Paul Galea
8d6520964f Avoid variable aliases. 2015-09-15 17:24:04 +00:00
Jean Paul Galea
99e6d8586d Avoid variable aliases. 2015-09-15 16:34:34 +00:00
Jean Paul Galea
fbbc03dcee Avoid variable aliases. 2015-09-15 16:33:30 +00:00
Jean Paul Galea
6443bbc01c Avoid variable aliases. 2015-09-15 16:31:54 +00:00
Jean Paul Galea
ba29b63be1 Avoid variable aliases. 2015-09-15 16:29:07 +00:00
Jean Paul Galea
c9e1c0c54a Bump versions. 2015-09-14 15:46:33 +02:00
Jean Paul Galea
d3788cc322 NEWS for 2.32 2015-09-14 15:41:00 +02:00
Jean Paul Galea
4433285c33 Refactor. 2015-09-10 20:58:04 +02:00
Jean Paul Galea
ad167cd38a Modified log messages. 
- avoid doing what is already handled by the Log class.

- the log name is appended automatically,
	so don't append it again in the invocation.

	i.e. "ykval-verify"

- the log level name is also appended automatically,
	so don't append it manually, especially when it doesn't match the log priority!

	i.e. LOG_WARNING -> ":notice:"

- fix whitespace in some messages.
 2015-09-10 20:53:56 +02:00
Jean Paul Galea
2df72604ed Cosmetic. 2015-09-10 20:37:24 +02:00
Jean Paul Galea
a1443857f7 Refactor. 2015-09-10 20:35:51 +02:00
Jean Paul Galea
694f5aee32 Refactor. 2015-09-10 20:33:35 +02:00
Jean Paul Galea
d34eb7895f Rename variable. 2015-09-10 20:32:21 +02:00
Jean Paul Galea
5d9459ec5c Rename variable. 2015-09-10 20:31:39 +02:00
Jean Paul Galea
06bf821555 Refactor. 
- make it easier to follow,
	create prefix first, then suffix.
 2015-09-10 20:30:00 +02:00
Jean Paul Galea
2c5d0a6efa Refactor. 
- build separate string from $extra array,
	and append it in syslog call.
 2015-09-10 20:28:37 +02:00
Jean Paul Galea
d6433c81ab Rename variable. 2015-09-10 20:25:20 +02:00
Jean Paul Galea
a3421284e1 Refactor. 2015-09-10 20:24:23 +02:00
Jean Paul Galea
f71b81fe6b Refactor. 
- init variables as class property,
	no need to init in construct.

- set scopes on private properties,
	and public methods.
 2015-09-10 20:17:22 +02:00
Jean Paul Galea
7503d42699 Refactor. 
- get rid of log_format() function.

- was only used in one place and it just complicates things.
 2015-09-10 20:02:07 +02:00
Jean Paul Galea
4b79e45683 Documentation. 2015-09-10 19:59:11 +02:00
Jean Paul Galea
bc660a1f34 Cosmetic. 2015-09-10 19:55:14 +02:00
Jean Paul Galea
4a8eeacf7a Refactor. 
- $urls is already checked prior to invoking function.
 2015-09-10 19:54:45 +02:00
Jean Paul Galea
3f3ffaf493 Bump versions. 2015-09-10 11:30:10 +02:00
Jean Paul Galea
b05998aba4 Cosmetic fix. 2015-09-10 11:17:16 +02:00
Jean Paul Galea
94021e6398 NEWS for 2.31 2015-09-10 11:14:50 +02:00
Jean Paul Galea
e6e379762a Fix bug. 
- fix fatal error when an empty sync request is sent to the server.

- logging boilerplate must be initiated before we start validating the request.
 2015-09-09 15:17:01 +02:00
Jean Paul Galea
eec70dad47 Fix bug. 
- argument to sprintf, not concat to first argument!
 2015-09-09 15:11:08 +02:00
Jean Paul Galea
c99fdb2129 Bump versions. 2015-09-09 10:52:35 +02:00
Jean Paul Galea
9e3efc267e NEWS for 2.30 2015-09-09 09:58:06 +02:00
Jean Paul Galea
88707ec442 Fix. 
- add newline for munin error message.
 2015-09-09 09:55:21 +02:00
Jean Paul Galea
5381074a73 Refactor out function into library. 2015-09-08 17:45:37 +02:00
Jean Paul Galea
f2483a6ff9 Rewrote ykval-munin-queuelength plugin. 
- bring in line with ksm and val latency plugin.
 2015-09-08 17:10:31 +02:00
Jean Paul Galea
f566a75dcd Rewrite ykval-munin-ksmlatency plugin. 
- same as 1e4da5dac6,
	but for ksm latency plugin.
 2015-09-08 16:47:16 +02:00
Jean Paul Galea
1e4da5dac6 Rewrite ykval-munin-vallatency plugin. 
- avoid having to use the same internal and label name,
	as it's problematic.

- internal name has a lot of restrictions:
	s/^[^A-Za-z_]/_/
	s/[^A-Za-z0-9_]/_/g

- which doesn't allow us to show proper label names,
	the names that users will see.

- label displays :80 or :443 depending on scheme.

- avoid ugliness with shortname() and instead use endpoints().
 2015-09-08 16:41:15 +02:00
Jean Paul Galea
d6e7f317c3 Cosmetic. 2015-09-08 14:57:39 +02:00
Jean Paul Galea
446d1c58ee Use underscore instead of colon for host/port. 
- munin plugin only supports a-zA-Z0-9_ so colon will probably give us problems.
 2015-09-08 14:56:02 +02:00
Jean Paul Galea
780b0eff13 Fix. 
- import common, required for shortname function.
 2015-09-08 14:51:20 +02:00
Jean Paul Galea
b8e98e6049 Add shortname failure checks for munin plugins. 2015-09-08 14:47:34 +02:00
Jean Paul Galea
21b795b852 Rename function 2015-09-08 14:42:11 +02:00